From 024091e6b5c5d3e59c30371e74fe8491fdceda4d Mon Sep 17 00:00:00 2001 From: "Markus F.X.J. Oberhumer" Date: Wed, 31 Jan 2024 20:52:19 +0100 Subject: [PATCH] src: fix previous bounds checking commit --- src/util/membuffer.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/membuffer.h b/src/util/membuffer.h index 9f18b999..8d3b8b2a 100644 --- a/src/util/membuffer.h +++ b/src/util/membuffer.h @@ -57,7 +57,8 @@ public: // array access reference operator[](ptrdiff_t i) const may_throw { - if very_unlikely (i < 0 || mem_size(sizeof(element_type), i) >= size_in_bytes) + // TODO: &array[SIZE] == array + SIZE, this is legal; but element access is not + if very_unlikely (i < 0 || mem_size(sizeof(element_type), i) > size_in_bytes) throwCantPack("MemBuffer invalid index %td (%u bytes)", i, size_in_bytes); return ptr[i]; }