jory/upx
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

clang-format files.

Browse Source
This commit is contained in:
Markus F.X.J. Oberhumer
2017-07-22 12:47:45 +02:00
parent 6de021d8d8
commit 33dc947c21
5 changed files with 170 additions and 264 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Makefile
+2 -2
View File
@@ -163,11 +163,11 @@ endif
# automatically format some C++ source code files # automatically format some C++ source code files
ifeq ($(shell uname),Linux) ifeq ($(shell uname),Linux)
CLANG_FORMAT_FILES += linker.cpp linker.h packhead.cpp packmast.cpp CLANG_FORMAT_FILES += linker.cpp linker.h packhead.cpp packmast.cpp packmast.h
CLANG_FORMAT_FILES += s_djgpp2.cpp s_object.cpp s_vcsa.cpp s_win32.cpp screen.h CLANG_FORMAT_FILES += s_djgpp2.cpp s_object.cpp s_vcsa.cpp s_win32.cpp screen.h
CLANG_FORMAT_FILES += snprintf.cpp CLANG_FORMAT_FILES += snprintf.cpp
CLANG_FORMAT_FILES += stdcxx.cpp stdcxx.h CLANG_FORMAT_FILES += stdcxx.cpp stdcxx.h
CLANG_FORMAT_FILES += ui.cpp ui.h util.h CLANG_FORMAT_FILES += ui.cpp ui.h util.cpp util.h work.cpp
clang-format: clang-format:
$(top_srcdir)/src/stub/scripts/upx-clang-format -i $(addprefix $(top_srcdir)/src/,$(CLANG_FORMAT_FILES)) $(top_srcdir)/src/stub/scripts/upx-clang-format -i $(addprefix $(top_srcdir)/src/,$(CLANG_FORMAT_FILES))
.PHONY: clang-format .PHONY: clang-format
src/packmast.h
+1 -5
View File
@@ -25,7 +25,6 @@
<markus@oberhumer.com> <ezerotven+github@gmail.com> <markus@oberhumer.com> <ezerotven+github@gmail.com>
*/ */
#ifndef __UPX_PACKMASTER_H #ifndef __UPX_PACKMASTER_H
#define __UPX_PACKMASTER_H 1 #define __UPX_PACKMASTER_H 1
@@ -33,13 +32,11 @@ class Packer;
class InputFile; class InputFile;
class OutputFile; class OutputFile;
/************************************************************************* /*************************************************************************
// interface for work.cpp // interface for work.cpp
**************************************************************************/ **************************************************************************/
class PackMaster class PackMaster {
{
public: public:
PackMaster(InputFile *f, options_t *o = NULL); PackMaster(InputFile *f, options_t *o = NULL);
virtual ~PackMaster(); virtual ~PackMaster();
@@ -65,7 +62,6 @@ private:
options_t *saved_opt; options_t *saved_opt;
}; };
#endif /* already included */ #endif /* already included */
/* vim:set ts=4 sw=4 et: */ /* vim:set ts=4 sw=4 et: */
src/util.cpp
+84 -145
View File
@@ -25,7 +25,6 @@
<markus@oberhumer.com> <ezerotven+github@gmail.com> <markus@oberhumer.com> <ezerotven+github@gmail.com>
*/ */
#include "conf.h" #include "conf.h"
#include "util.h" #include "util.h"
@@ -45,7 +44,6 @@
#undef HAVE_MKDIR #undef HAVE_MKDIR
#include "miniacc.h" #include "miniacc.h"
/************************************************************************* /*************************************************************************
// assert sane memory buffer sizes to protect against integer overflows // assert sane memory buffer sizes to protect against integer overflows
// and malicious header fields // and malicious header fields
@@ -55,45 +53,52 @@ ACC_COMPILE_TIME_ASSERT_HEADER(UPX_RSIZE_MAX_MEM == UPX_RSIZE_MAX)
ACC_COMPILE_TIME_ASSERT_HEADER(UPX_RSIZE_MAX_STR <= UPX_RSIZE_MAX / 256) ACC_COMPILE_TIME_ASSERT_HEADER(UPX_RSIZE_MAX_STR <= UPX_RSIZE_MAX / 256)
ACC_COMPILE_TIME_ASSERT_HEADER(2ull * UPX_RSIZE_MAX * 9 / 8 + 16 * 1024 * 1024 < INT_MAX) ACC_COMPILE_TIME_ASSERT_HEADER(2ull * UPX_RSIZE_MAX * 9 / 8 + 16 * 1024 * 1024 < INT_MAX)
upx_rsize_t mem_size(upx_uint64_t element_size, upx_uint64_t n, upx_uint64_t extra1, upx_uint64_t extra2) upx_rsize_t mem_size(upx_uint64_t element_size, upx_uint64_t n, upx_uint64_t extra1,
{ upx_uint64_t extra2) {
assert(element_size > 0); assert(element_size > 0);
if (element_size > UPX_RSIZE_MAX) throwCantPack("mem_size 1; take care"); if (element_size > UPX_RSIZE_MAX)
if (n > UPX_RSIZE_MAX) throwCantPack("mem_size 2; take care"); throwCantPack("mem_size 1; take care");
if (extra1 > UPX_RSIZE_MAX) throwCantPack("mem_size 3; take care"); if (n > UPX_RSIZE_MAX)
if (extra2 > UPX_RSIZE_MAX) throwCantPack("mem_size 4; take care"); throwCantPack("mem_size 2; take care");
if (extra1 > UPX_RSIZE_MAX)
throwCantPack("mem_size 3; take care");
if (extra2 > UPX_RSIZE_MAX)
throwCantPack("mem_size 4; take care");
upx_uint64_t bytes = element_size * n + extra1 + extra2; // cannot overflow upx_uint64_t bytes = element_size * n + extra1 + extra2; // cannot overflow
if (bytes > UPX_RSIZE_MAX) throwCantPack("mem_size 5; take care"); if (bytes > UPX_RSIZE_MAX)
throwCantPack("mem_size 5; take care");
return ACC_ICONV(upx_rsize_t, bytes); return ACC_ICONV(upx_rsize_t, bytes);
} }
upx_rsize_t mem_size_get_n(upx_uint64_t element_size, upx_uint64_t n) upx_rsize_t mem_size_get_n(upx_uint64_t element_size, upx_uint64_t n) {
{
mem_size_assert(element_size, n); mem_size_assert(element_size, n);
return ACC_ICONV(upx_rsize_t, n); // return n return ACC_ICONV(upx_rsize_t, n); // return n
} }
bool mem_size_valid(upx_uint64_t element_size, upx_uint64_t n, upx_uint64_t extra1, upx_uint64_t extra2) bool mem_size_valid(upx_uint64_t element_size, upx_uint64_t n, upx_uint64_t extra1,
{ upx_uint64_t extra2) {
assert(element_size > 0); assert(element_size > 0);
if (element_size > UPX_RSIZE_MAX) return false; if (element_size > UPX_RSIZE_MAX)
if (n > UPX_RSIZE_MAX) return false; return false;
if (extra1 > UPX_RSIZE_MAX) return false; if (n > UPX_RSIZE_MAX)
if (extra2 > UPX_RSIZE_MAX) return false; return false;
if (extra1 > UPX_RSIZE_MAX)
return false;
if (extra2 > UPX_RSIZE_MAX)
return false;
upx_uint64_t bytes = element_size * n + extra1 + extra2; // cannot overflow upx_uint64_t bytes = element_size * n + extra1 + extra2; // cannot overflow
if (bytes > UPX_RSIZE_MAX) return false; if (bytes > UPX_RSIZE_MAX)
return false;
return true; return true;
} }
bool mem_size_valid_bytes(upx_uint64_t bytes) bool mem_size_valid_bytes(upx_uint64_t bytes) {
{ if (bytes > UPX_RSIZE_MAX)
if (bytes > UPX_RSIZE_MAX) return false; return false;
return true; return true;
} }
int ptr_diff(const void *p1, const void *p2) {
int ptr_diff(const void *p1, const void *p2)
{
assert(p1 != NULL); assert(p1 != NULL);
assert(p2 != NULL); assert(p2 != NULL);
ptrdiff_t d = (const char *) p1 - (const char *) p2; ptrdiff_t d = (const char *) p1 - (const char *) p2;
@@ -104,14 +109,12 @@ int ptr_diff(const void *p1, const void *p2)
return ACC_ICONV(int, d); return ACC_ICONV(int, d);
} }
unsigned ptr_udiff(const void *p1, const void *p2) unsigned ptr_udiff(const void *p1, const void *p2) {
{
int d = ptr_diff(p1, p2); int d = ptr_diff(p1, p2);
assert(d >= 0); assert(d >= 0);
return ACC_ICONV(unsigned, d); return ACC_ICONV(unsigned, d);
} }
/************************************************************************* /*************************************************************************
// bele.h // bele.h
**************************************************************************/ **************************************************************************/
@@ -126,131 +129,111 @@ const BEPolicy be_policy;
const LEPolicy le_policy; const LEPolicy le_policy;
} }
/************************************************************************* /*************************************************************************
// qsort() util // qsort() util
**************************************************************************/ **************************************************************************/
int __acc_cdecl_qsort be16_compare(const void *e1, const void *e2) int __acc_cdecl_qsort be16_compare(const void *e1, const void *e2) {
{
const unsigned d1 = get_be16(e1); const unsigned d1 = get_be16(e1);
const unsigned d2 = get_be16(e2); const unsigned d2 = get_be16(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort be24_compare(const void *e1, const void *e2) int __acc_cdecl_qsort be24_compare(const void *e1, const void *e2) {
{
const unsigned d1 = get_be24(e1); const unsigned d1 = get_be24(e1);
const unsigned d2 = get_be24(e2); const unsigned d2 = get_be24(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort be32_compare(const void *e1, const void *e2) int __acc_cdecl_qsort be32_compare(const void *e1, const void *e2) {
{
const unsigned d1 = get_be32(e1); const unsigned d1 = get_be32(e1);
const unsigned d2 = get_be32(e2); const unsigned d2 = get_be32(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort be64_compare(const void *e1, const void *e2) int __acc_cdecl_qsort be64_compare(const void *e1, const void *e2) {
{
const upx_uint64_t d1 = get_be64(e1); const upx_uint64_t d1 = get_be64(e1);
const upx_uint64_t d2 = get_be64(e2); const upx_uint64_t d2 = get_be64(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort le16_compare(const void *e1, const void *e2) int __acc_cdecl_qsort le16_compare(const void *e1, const void *e2) {
{
const unsigned d1 = get_le16(e1); const unsigned d1 = get_le16(e1);
const unsigned d2 = get_le16(e2); const unsigned d2 = get_le16(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort le24_compare(const void *e1, const void *e2) int __acc_cdecl_qsort le24_compare(const void *e1, const void *e2) {
{
const unsigned d1 = get_le24(e1); const unsigned d1 = get_le24(e1);
const unsigned d2 = get_le24(e2); const unsigned d2 = get_le24(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort le32_compare(const void *e1, const void *e2) int __acc_cdecl_qsort le32_compare(const void *e1, const void *e2) {
{
const unsigned d1 = get_le32(e1); const unsigned d1 = get_le32(e1);
const unsigned d2 = get_le32(e2); const unsigned d2 = get_le32(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort le64_compare(const void *e1, const void *e2) int __acc_cdecl_qsort le64_compare(const void *e1, const void *e2) {
{
const upx_uint64_t d1 = get_le64(e1); const upx_uint64_t d1 = get_le64(e1);
const upx_uint64_t d2 = get_le64(e2); const upx_uint64_t d2 = get_le64(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort be16_compare_signed(const void *e1, const void *e2) {
int __acc_cdecl_qsort be16_compare_signed(const void *e1, const void *e2)
{
const int d1 = get_be16_signed(e1); const int d1 = get_be16_signed(e1);
const int d2 = get_be16_signed(e2); const int d2 = get_be16_signed(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort be24_compare_signed(const void *e1, const void *e2) int __acc_cdecl_qsort be24_compare_signed(const void *e1, const void *e2) {
{
const int d1 = get_be24_signed(e1); const int d1 = get_be24_signed(e1);
const int d2 = get_be24_signed(e2); const int d2 = get_be24_signed(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort be32_compare_signed(const void *e1, const void *e2) int __acc_cdecl_qsort be32_compare_signed(const void *e1, const void *e2) {
{
const int d1 = get_be32_signed(e1); const int d1 = get_be32_signed(e1);
const int d2 = get_be32_signed(e2); const int d2 = get_be32_signed(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort be64_compare_signed(const void *e1, const void *e2) int __acc_cdecl_qsort be64_compare_signed(const void *e1, const void *e2) {
{
const upx_int64_t d1 = get_be64_signed(e1); const upx_int64_t d1 = get_be64_signed(e1);
const upx_int64_t d2 = get_be64_signed(e2); const upx_int64_t d2 = get_be64_signed(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort le16_compare_signed(const void *e1, const void *e2) int __acc_cdecl_qsort le16_compare_signed(const void *e1, const void *e2) {
{
const int d1 = get_le16_signed(e1); const int d1 = get_le16_signed(e1);
const int d2 = get_le16_signed(e2); const int d2 = get_le16_signed(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort le24_compare_signed(const void *e1, const void *e2) int __acc_cdecl_qsort le24_compare_signed(const void *e1, const void *e2) {
{
const int d1 = get_le24_signed(e1); const int d1 = get_le24_signed(e1);
const int d2 = get_le24_signed(e2); const int d2 = get_le24_signed(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort le32_compare_signed(const void *e1, const void *e2) int __acc_cdecl_qsort le32_compare_signed(const void *e1, const void *e2) {
{
const int d1 = get_le32_signed(e1); const int d1 = get_le32_signed(e1);
const int d2 = get_le32_signed(e2); const int d2 = get_le32_signed(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
int __acc_cdecl_qsort le64_compare_signed(const void *e1, const void *e2) int __acc_cdecl_qsort le64_compare_signed(const void *e1, const void *e2) {
{
const upx_int64_t d1 = get_le64_signed(e1); const upx_int64_t d1 = get_le64_signed(e1);
const upx_int64_t d2 = get_le64_signed(e2); const upx_int64_t d2 = get_le64_signed(e2);
return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0); return (d1 < d2) ? -1 : ((d1 > d2) ? 1 : 0);
} }
/************************************************************************* /*************************************************************************
// find util // find util
**************************************************************************/ **************************************************************************/
int find(const void *b, int blen, const void *what, int wlen) int find(const void *b, int blen, const void *what, int wlen) {
{
if (b == NULL || blen <= 0 || what == NULL || wlen <= 0) if (b == NULL || blen <= 0 || what == NULL || wlen <= 0)
return -1; return -1;
@@ -266,63 +249,48 @@ int find(const void *b, int blen, const void *what, int wlen)
return -1; return -1;
} }
int find_be16(const void *b, int blen, unsigned what) {
int find_be16(const void *b, int blen, unsigned what)
{
unsigned char w[2]; unsigned char w[2];
set_be16(w, what); set_be16(w, what);
return find(b, blen, w, 2); return find(b, blen, w, 2);
} }
int find_be32(const void *b, int blen, unsigned what) {
int find_be32(const void *b, int blen, unsigned what)
{
unsigned char w[4]; unsigned char w[4];
set_be32(w, what); set_be32(w, what);
return find(b, blen, w, 4); return find(b, blen, w, 4);
} }
int find_be64(const void *b, int blen, upx_uint64_t what) {
int find_be64(const void *b, int blen, upx_uint64_t what)
{
unsigned char w[8]; unsigned char w[8];
set_be64(w, what); set_be64(w, what);
return find(b, blen, w, 8); return find(b, blen, w, 8);
} }
int find_le16(const void *b, int blen, unsigned what) {
int find_le16(const void *b, int blen, unsigned what)
{
unsigned char w[2]; unsigned char w[2];
set_le16(w, what); set_le16(w, what);
return find(b, blen, w, 2); return find(b, blen, w, 2);
} }
int find_le32(const void *b, int blen, unsigned what) {
int find_le32(const void *b, int blen, unsigned what)
{
unsigned char w[4]; unsigned char w[4];
set_le32(w, what); set_le32(w, what);
return find(b, blen, w, 4); return find(b, blen, w, 4);
} }
int find_le64(const void *b, int blen, upx_uint64_t what) {
int find_le64(const void *b, int blen, upx_uint64_t what)
{
unsigned char w[8]; unsigned char w[8];
set_le64(w, what); set_le64(w, what);
return find(b, blen, w, 8); return find(b, blen, w, 8);
} }
int mem_replace(void *bb, int blen, const void *what, int wlen, const void *r) {
int mem_replace(void *bb, int blen, const void *what, int wlen, const void *r)
{
unsigned char *b = (unsigned char *) bb; unsigned char *b = (unsigned char *) bb;
int boff = 0; int boff = 0;
int n = 0; int n = 0;
while (blen - boff >= wlen) while (blen - boff >= wlen) {
{
int off = find(b + boff, blen - boff, what, wlen); int off = find(b + boff, blen - boff, what, wlen);
if (off < 0) if (off < 0)
break; break;
@@ -334,12 +302,12 @@ int mem_replace(void *bb, int blen, const void *what, int wlen, const void *r)
return n; return n;
} }
/************************************************************************* /*************************************************************************
// fn - FileName util // fn - FileName util
**************************************************************************/ **************************************************************************/
#if (ACC_OS_CYGWIN || ACC_OS_DOS16 || ACC_OS_DOS32 || ACC_OS_EMX || ACC_OS_OS2 || ACC_OS_OS16 || ACC_OS_TOS || ACC_OS_WIN16 || ACC_OS_WIN32 || ACC_OS_WIN64) #if (ACC_OS_CYGWIN || ACC_OS_DOS16 || ACC_OS_DOS32 || ACC_OS_EMX || ACC_OS_OS2 || ACC_OS_OS16 || \
ACC_OS_TOS || ACC_OS_WIN16 || ACC_OS_WIN32 || ACC_OS_WIN64)
static const char dir_sep[] = "/\\"; static const char dir_sep[] = "/\\";
#define fn_is_drive(s) (s[0] && s[1] == ':') #define fn_is_drive(s) (s[0] && s[1] == ':')
@@ -357,9 +325,7 @@ static const char dir_sep[] = "/\\";
#endif #endif
char *fn_basename(const char *name) {
char *fn_basename(const char *name)
{
const char *n, *nn; const char *n, *nn;
name = fn_skip_drive(name); name = fn_skip_drive(name);
@@ -369,9 +335,7 @@ char *fn_basename(const char *name)
return ACC_UNCONST_CAST(char *, n); return ACC_UNCONST_CAST(char *, n);
} }
bool fn_has_ext(const char *name, const char *ext, bool ignore_case) {
bool fn_has_ext(const char *name, const char *ext, bool ignore_case)
{
const char *n, *e; const char *n, *e;
name = fn_basename(name); name = fn_basename(name);
@@ -384,39 +348,32 @@ bool fn_has_ext(const char *name, const char *ext, bool ignore_case)
return (fn_strcmp(ext, e + 1) == 0); return (fn_strcmp(ext, e + 1) == 0);
} }
char *fn_strlwr(char *n) {
char *fn_strlwr(char *n)
{
char *p; char *p;
for (p = n; *p; p++) for (p = n; *p; p++)
*p = (char) fn_tolower(*p); *p = (char) fn_tolower(*p);
return n; return n;
} }
int fn_strcmp(const char *n1, const char *n2) {
int fn_strcmp(const char *n1, const char *n2) for (;;) {
{ if (*n1 != *n2) {
for (;;)
{
if (*n1 != *n2)
{
int c = fn_tolower(*n1) - fn_tolower(*n2); int c = fn_tolower(*n1) - fn_tolower(*n2);
if (c) if (c)
return c; return c;
} }
if (*n1 == 0) if (*n1 == 0)
return 0; return 0;
n1++; n2++; n1++;
n2++;
} }
} }
/************************************************************************* /*************************************************************************
// misc. // misc.
**************************************************************************/ **************************************************************************/
bool set_method_name(char *buf, size_t size, int method, int level) bool set_method_name(char *buf, size_t size, int method, int level) {
{
bool r = true; bool r = true;
const char *alg; const char *alg;
if (M_IS_NRV2B(method)) if (M_IS_NRV2B(method))
@@ -427,8 +384,7 @@ bool set_method_name(char *buf, size_t size, int method, int level)
alg = "NRV2E"; alg = "NRV2E";
else if (M_IS_LZMA(method)) else if (M_IS_LZMA(method))
alg = "LZMA"; alg = "LZMA";
else else {
{
alg = "???"; alg = "???";
r = false; r = false;
} }
@@ -439,9 +395,7 @@ bool set_method_name(char *buf, size_t size, int method, int level)
return r; return r;
} }
void center_string(char *buf, size_t size, const char *s) {
void center_string(char *buf, size_t size, const char *s)
{
size_t l1 = size - 1; size_t l1 = size - 1;
size_t l2 = strlen(s); size_t l2 = strlen(s);
assert(size > 0); assert(size > 0);
@@ -451,16 +405,13 @@ void center_string(char *buf, size_t size, const char *s)
buf[l1] = 0; buf[l1] = 0;
} }
bool file_exists(const char *name) {
bool file_exists(const char *name)
{
int fd, r; int fd, r;
struct stat st; struct stat st;
/* return true if we can open it */ /* return true if we can open it */
fd = open(name, O_RDONLY | O_BINARY, 0); fd = open(name, O_RDONLY | O_BINARY, 0);
if (fd >= 0) if (fd >= 0) {
{
(void) close(fd); (void) close(fd);
return true; return true;
} }
@@ -482,10 +433,8 @@ bool file_exists(const char *name)
return false; return false;
} }
bool maketempname(char *ofilename, size_t size, const char *ifilename, const char *ext,
bool maketempname(char *ofilename, size_t size, bool force) {
const char *ifilename, const char *ext, bool force)
{
char *ofext = NULL, *ofname; char *ofext = NULL, *ofname;
int ofile; int ofile;
@@ -493,8 +442,7 @@ bool maketempname(char *ofilename, size_t size,
return false; return false;
strcpy(ofilename, ifilename); strcpy(ofilename, ifilename);
for (ofname = fn_basename(ofilename); *ofname; ofname++) for (ofname = fn_basename(ofilename); *ofname; ofname++) {
{
if (*ofname == '.') if (*ofname == '.')
ofext = ofname; ofext = ofname;
} }
@@ -502,8 +450,7 @@ bool maketempname(char *ofilename, size_t size,
ofext = ofilename + strlen(ofilename); ofext = ofilename + strlen(ofilename);
strcpy(ofext, ext); strcpy(ofext, ext);
for (ofile = 0; ofile < 1000; ofile++) for (ofile = 0; ofile < 1000; ofile++) {
{
assert(strlen(ofilename) < size); assert(strlen(ofilename) < size);
if (!file_exists(ofilename)) if (!file_exists(ofilename))
return true; return true;
@@ -516,10 +463,7 @@ bool maketempname(char *ofilename, size_t size,
return false; return false;
} }
bool makebakname(char *ofilename, size_t size, const char *ifilename, bool force) {
bool makebakname(char *ofilename, size_t size,
const char *ifilename, bool force)
{
char *ofext = NULL, *ofname; char *ofext = NULL, *ofname;
int ofile; int ofile;
@@ -527,23 +471,19 @@ bool makebakname(char *ofilename, size_t size,
return false; return false;
strcpy(ofilename, ifilename); strcpy(ofilename, ifilename);
for (ofname = fn_basename(ofilename); *ofname; ofname++) for (ofname = fn_basename(ofilename); *ofname; ofname++) {
{
if (*ofname == '.') if (*ofname == '.')
ofext = ofname; ofext = ofname;
} }
if (ofext == NULL) if (ofext == NULL) {
{
ofext = ofilename + strlen(ofilename); ofext = ofilename + strlen(ofilename);
strcpy(ofext, ".~"); strcpy(ofext, ".~");
} } else if (strlen(ofext) < 1 + 3)
else if (strlen(ofext) < 1 + 3)
strcat(ofilename, "~"); strcat(ofilename, "~");
else else
ofext[strlen(ofext) - 1] = '~'; ofext[strlen(ofext) - 1] = '~';
for (ofile = 0; ofile < 1000; ofile++) for (ofile = 0; ofile < 1000; ofile++) {
{
assert(strlen(ofilename) < size); assert(strlen(ofilename) < size);
if (!file_exists(ofilename)) if (!file_exists(ofilename))
return true; return true;
@@ -556,13 +496,11 @@ bool makebakname(char *ofilename, size_t size,
return false; return false;
} }
/************************************************************************* /*************************************************************************
// return compression ratio, where 100% == 1000*1000 == 1e6 // return compression ratio, where 100% == 1000*1000 == 1e6
**************************************************************************/ **************************************************************************/
unsigned get_ratio(upx_uint64_t u_len, upx_uint64_t c_len) unsigned get_ratio(upx_uint64_t u_len, upx_uint64_t c_len) {
{
const unsigned n = 1000 * 1000; const unsigned n = 1000 * 1000;
if (u_len == 0) if (u_len == 0)
return c_len == 0 ? 0 : n; return c_len == 0 ? 0 : n;
@@ -575,7 +513,6 @@ unsigned get_ratio(upx_uint64_t u_len, upx_uint64_t c_len)
return ACC_ICONV(unsigned, x); return ACC_ICONV(unsigned, x);
} }
/************************************************************************* /*************************************************************************
// Don't link these functions from libc ==> save xxx bytes // Don't link these functions from libc ==> save xxx bytes
**************************************************************************/ **************************************************************************/
@@ -584,7 +521,10 @@ extern "C" {
// FIXME - quick hack for arm-wince-gcc-3.4 (Debian pocketpc-*.deb packages) // FIXME - quick hack for arm-wince-gcc-3.4 (Debian pocketpc-*.deb packages)
#if 1 && (ACC_ARCH_ARM) && defined(__pe__) && !defined(__CEGCC__) && !defined(_WIN32) #if 1 && (ACC_ARCH_ARM) && defined(__pe__) && !defined(__CEGCC__) && !defined(_WIN32)
int dup(int fd) { UNUSED(fd); return -1; } int dup(int fd) {
UNUSED(fd);
return -1;
}
#endif #endif
#if (ACC_OS_DOS32) && defined(__DJGPP__) #if (ACC_OS_DOS32) && defined(__DJGPP__)
@@ -596,7 +536,6 @@ int dup(int fd) { UNUSED(fd); return -1; }
// time_t time(time_t *t) { if (t) *t = 0; return 0; } // time_t time(time_t *t) { if (t) *t = 0; return 0; }
#endif #endif
} // extern "C" } // extern "C"
/* vim:set ts=4 sw=4 et: */ /* vim:set ts=4 sw=4 et: */
src/work.cpp
+22 -51
View File
@@ -25,14 +25,12 @@
<markus@oberhumer.com> <ezerotven+github@gmail.com> <markus@oberhumer.com> <ezerotven+github@gmail.com>
*/ */
#include "conf.h" #include "conf.h"
#include "file.h" #include "file.h"
#include "packmast.h" #include "packmast.h"
#include "packer.h" #include "packer.h"
#include "ui.h" #include "ui.h"
#if (ACC_OS_DOS32) && defined(__DJGPP__) #if (ACC_OS_DOS32) && defined(__DJGPP__)
#define USE_FTIME 1 #define USE_FTIME 1
#elif (ACC_OS_WIN32 && ACC_CC_MWERKS) && defined(__MSL__) #elif (ACC_OS_WIN32 && ACC_CC_MWERKS) && defined(__MSL__)
@@ -54,13 +52,11 @@
// ignore errors in some cases and silence __attribute__((__warn_unused_result__)) // ignore errors in some cases and silence __attribute__((__warn_unused_result__))
#define IGNORE_ERROR(var) ACC_UNUSED(var) #define IGNORE_ERROR(var) ACC_UNUSED(var)
/************************************************************************* /*************************************************************************
// process one file // process one file
**************************************************************************/ **************************************************************************/
void do_one_file(const char *iname, char *oname) void do_one_file(const char *iname, char *oname) {
{
int r; int r;
struct stat st; struct stat st;
memset(&st, 0, sizeof(st)); memset(&st, 0, sizeof(st));
@@ -69,8 +65,7 @@ void do_one_file(const char *iname, char *oname)
#else #else
r = stat(iname, &st); r = stat(iname, &st);
#endif #endif
if (r != 0) if (r != 0) {
{
if (errno == ENOENT) if (errno == ENOENT)
throw FileNotFoundException(iname, errno); throw FileNotFoundException(iname, errno);
else else
@@ -89,8 +84,7 @@ void do_one_file(const char *iname, char *oname)
throwIOException("file is too small -- skipped"); throwIOException("file is too small -- skipped");
if (!mem_size_valid_bytes(st.st_size)) if (!mem_size_valid_bytes(st.st_size))
throwIOException("file is too large -- skipped"); throwIOException("file is too large -- skipped");
if ((st.st_mode & S_IWUSR) == 0) if ((st.st_mode & S_IWUSR) == 0) {
{
bool skip = true; bool skip = true;
if (opt->output_name) if (opt->output_name)
skip = false; skip = false;
@@ -109,8 +103,7 @@ void do_one_file(const char *iname, char *oname)
#if (USE_FTIME) #if (USE_FTIME)
struct ftime fi_ftime; struct ftime fi_ftime;
memset(&fi_ftime, 0, sizeof(fi_ftime)); memset(&fi_ftime, 0, sizeof(fi_ftime));
if (opt->preserve_timestamp) if (opt->preserve_timestamp) {
{
if (getftime(fi.getFd(), &fi_ftime) != 0) if (getftime(fi.getFd(), &fi_ftime) != 0)
throwIOException("cannot determine file timestamp"); throwIOException("cannot determine file timestamp");
} }
@@ -118,25 +111,19 @@ void do_one_file(const char *iname, char *oname)
// open output file // open output file
OutputFile fo; OutputFile fo;
if (opt->cmd == CMD_COMPRESS || opt->cmd == CMD_DECOMPRESS) if (opt->cmd == CMD_COMPRESS || opt->cmd == CMD_DECOMPRESS) {
{ if (opt->to_stdout) {
if (opt->to_stdout)
{
if (!fo.openStdout(1, opt->force ? true : false)) if (!fo.openStdout(1, opt->force ? true : false))
throwIOException("data not written to a terminal; Use '-f' to force."); throwIOException("data not written to a terminal; Use '-f' to force.");
} } else {
else
{
char tname[ACC_FN_PATH_MAX + 1]; char tname[ACC_FN_PATH_MAX + 1];
if (opt->output_name) if (opt->output_name)
strcpy(tname, opt->output_name); strcpy(tname, opt->output_name);
else else {
{
if (!maketempname(tname, sizeof(tname), iname, ".upx")) if (!maketempname(tname, sizeof(tname), iname, ".upx"))
throwIOException("could not create a temporary file name"); throwIOException("could not create a temporary file name");
} }
if (opt->force >= 2) if (opt->force >= 2) {
{
#if (HAVE_CHMOD) #if (HAVE_CHMOD)
r = chmod(tname, 0777); r = chmod(tname, 0777);
IGNORE_ERROR(r); IGNORE_ERROR(r);
@@ -181,8 +168,7 @@ void do_one_file(const char *iname, char *oname)
throwInternalError("invalid command"); throwInternalError("invalid command");
// copy time stamp // copy time stamp
if (opt->preserve_timestamp && oname[0] && fo.isOpen()) if (opt->preserve_timestamp && oname[0] && fo.isOpen()) {
{
#if (USE_FTIME) #if (USE_FTIME)
r = setftime(fo.getFd(), &fi_ftime); r = setftime(fo.getFd(), &fi_ftime);
IGNORE_ERROR(r); IGNORE_ERROR(r);
@@ -200,19 +186,15 @@ void do_one_file(const char *iname, char *oname)
fi.closex(); fi.closex();
// rename or delete files // rename or delete files
if (oname[0] && !opt->output_name) if (oname[0] && !opt->output_name) {
{
// FIXME: .exe or .cof etc. // FIXME: .exe or .cof etc.
if (!opt->backup) if (!opt->backup) {
{
#if (HAVE_CHMOD) #if (HAVE_CHMOD)
r = chmod(iname, 0777); r = chmod(iname, 0777);
IGNORE_ERROR(r); IGNORE_ERROR(r);
#endif #endif
File::unlink(iname); File::unlink(iname);
} } else {
else
{
// make backup // make backup
char bakname[ACC_FN_PATH_MAX + 1]; char bakname[ACC_FN_PATH_MAX + 1];
if (!makebakname(bakname, sizeof(bakname), iname)) if (!makebakname(bakname, sizeof(bakname), iname))
@@ -223,15 +205,13 @@ void do_one_file(const char *iname, char *oname)
} }
// copy file attributes // copy file attributes
if (oname[0]) if (oname[0]) {
{
oname[0] = 0; oname[0] = 0;
const char *name = opt->output_name ? opt->output_name : iname; const char *name = opt->output_name ? opt->output_name : iname;
UNUSED(name); UNUSED(name);
#if (USE_UTIME) #if (USE_UTIME)
// copy time stamp // copy time stamp
if (opt->preserve_timestamp) if (opt->preserve_timestamp) {
{
struct utimbuf u; struct utimbuf u;
u.actime = st.st_atime; u.actime = st.st_atime;
u.modtime = st.st_mtime; u.modtime = st.st_mtime;
@@ -241,16 +221,14 @@ void do_one_file(const char *iname, char *oname)
#endif #endif
#if (HAVE_CHMOD) #if (HAVE_CHMOD)
// copy permissions // copy permissions
if (opt->preserve_mode) if (opt->preserve_mode) {
{
r = chmod(name, st.st_mode); r = chmod(name, st.st_mode);
IGNORE_ERROR(r); IGNORE_ERROR(r);
} }
#endif #endif
#if (HAVE_CHOWN) #if (HAVE_CHOWN)
// copy the ownership // copy the ownership
if (opt->preserve_ownership) if (opt->preserve_ownership) {
{
r = chown(name, st.st_uid, st.st_gid); r = chown(name, st.st_uid, st.st_gid);
IGNORE_ERROR(r); IGNORE_ERROR(r);
} }
@@ -260,15 +238,12 @@ void do_one_file(const char *iname, char *oname)
UiPacker::uiConfirmUpdate(); UiPacker::uiConfirmUpdate();
} }
/************************************************************************* /*************************************************************************
// process all files from the commandline // process all files from the commandline
**************************************************************************/ **************************************************************************/
static void unlink_ofile(char *oname) static void unlink_ofile(char *oname) {
{ if (oname && oname[0]) {
if (oname && oname[0])
{
#if (HAVE_CHMOD) #if (HAVE_CHMOD)
int r; int r;
r = chmod(oname, 0777); r = chmod(oname, 0777);
@@ -279,17 +254,13 @@ static void unlink_ofile(char *oname)
} }
} }
void do_files(int i, int argc, char *argv[]) {
void do_files(int i, int argc, char *argv[]) if (opt->verbose >= 1) {
{
if (opt->verbose >= 1)
{
show_head(); show_head();
UiPacker::uiHeader(); UiPacker::uiHeader();
} }
for ( ; i < argc; i++) for (; i < argc; i++) {
{
infoHeader(); infoHeader();
const char *iname = argv[i]; const char *iname = argv[i];