CI updates

.github/workflows/weekly-ci-bs-by-hand.yml

@@ -8,13 +8,14 @@ on:
 env:
   CMAKE_REQUIRED_QUIET: OFF
   DEBIAN_FRONTEND: noninteractive
+  VERBOSE: 1
 
 jobs:
   job-alpine-by-hand: # uses a POSIX-compliant shell
     # ...and also uses a subdirectory "upx with space" in order to detect possible quoting issues
     # ...and also uses ccache as we are running the same build-script again and again
     if: github.repository_owner == 'upx'
-    strategy: { matrix: { container: ['alpine:3.9','alpine:3.18','alpine:edge'] } }
+    strategy: { matrix: { container: ['alpine:3.9','alpine:3.18','alpine:edge','i386/alpine:edge'] } }
     name: ${{ format('gcc by-hand {0}', matrix.container) }}
     runs-on: ubuntu-latest
     container: ${{ matrix.container }}
@@ -28,15 +29,17 @@ jobs:
           esac
           echo "installing shells: $shells"
           apk update && apk upgrade && apk add ccache g++ git $shells
-          # enable ccache
-          echo -e "CC=ccache gcc\nCXX=ccache g++ -std=gnu++17" >> $GITHUB_ENV
+          # enable ccache and some warnings
+          warn="-Wall -Wextra -Werror"
+          echo -e "CC=ccache gcc $warn\nCXX=ccache g++ -std=gnu++17 $warn" >> $GITHUB_ENV
           # this seems to be needed when running in a container (beause of UID mismatch??)
           git config --global --add safe.directory '*'
-      - name: 'Check out code'
-        uses: actions/checkout@v4
-        with:
-          submodules: true
-          path: 'upx with space'
+          # create user upx:upx 2000:2000 for file system tests below ("sudo")
+          adduser upx -u 2000 -D && cd /home/upx && chmod 00700 . && chown -R upx:upx .
+      - name: ${{ format('Check out UPX {0} source code', github.ref_name) }}
+        run: |
+          git clone --branch "$GITHUB_REF_NAME" --depth 1 https://github.com/upx/upx "upx with space"
+          git -C "upx with space" submodule update --init
       - name: 'Build by-hand with bash'
         run: 'bash "./upx with space/misc/scripts/build_upx_by_hand.sh"'
       - name: 'Build by-hand with bash --posix'
@@ -81,3 +84,17 @@ jobs:
         run: |
           ccache -s
           ccache -p
+      - name: 'Run file system test suite (busybox)'
+        run: |
+          apk add bash sudo
+          testsuite="$(readlink -fn "upx with space"/misc/testsuite/test_symlinks.sh)"
+          cd "upx with space"/build/by-hand
+          # IMPORTANT: do NOT run as user root!
+          chmod a+w . && sudo -u upx bash "$testsuite"
+      - name: 'Run file system test suite (coreutils)'
+        run: |
+          apk add bash coreutils sudo
+          testsuite="$(readlink -fn "upx with space"/misc/testsuite/test_symlinks.sh)"
+          cd "upx with space"/build/by-hand
+          # IMPORTANT: do NOT run as user root!
+          chmod a+w . && sudo -u upx bash "$testsuite"