jory/upx
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Check Mach_header.ncmds at unpack

Browse Source 
https://github.com/upx/upx/issues/563
	modified:   p_mach.cpp
This commit is contained in:
John Reiser
2022-02-25 09:32:29 -08:00
committed by Markus F.X.J. Oberhumer
parent 660aee6d22
commit 651155c64d
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/p_mach.cpp
+5
View File
@@ -1508,6 +1508,11 @@ void PackMachBase<T>::unpack(OutputFile *fo)
throwCantUnpack("file header corrupted"); throwCantUnpack("file header corrupted");
unsigned const ncmds = mhdr->ncmds; unsigned const ncmds = mhdr->ncmds;
if (!ncmds || 24 < ncmds) { // arbitrary limit
char msg[40]; snprintf(msg, sizeof(msg),
"bad Mach_header.ncmds = %d", ncmds);
throwCantUnpack(msg);
}
msegcmd_buf.alloc(sizeof(Mach_segment_command) * ncmds); msegcmd_buf.alloc(sizeof(Mach_segment_command) * ncmds);
msegcmd = (Mach_segment_command *)msegcmd_buf.getVoidPtr(); msegcmd = (Mach_segment_command *)msegcmd_buf.getVoidPtr();
unsigned char const *ptr = (unsigned char const *)(1+mhdr); unsigned char const *ptr = (unsigned char const *)(1+mhdr);