jory/upx
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Don't use variable length arrays (VLA).

Browse Source
This commit is contained in:
Markus F.X.J. Oberhumer
2016-10-06 13:04:46 +02:00
parent b3a8d02caf
commit 6e76f8ef3a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Makefile
+1 -1
View File
@@ -68,7 +68,7 @@ CXXFLAGS += -fno-delete-null-pointer-checks
endif endif
CXXFLAGS += -fno-strict-aliasing -fwrapv CXXFLAGS += -fno-strict-aliasing -fwrapv
CXXFLAGS += -funsigned-char CXXFLAGS += -funsigned-char
CXXFLAGS += -Wall -W -Wcast-align -Wcast-qual -Wmissing-declarations -Wpointer-arith -Wshadow -Wwrite-strings CXXFLAGS += -Wall -W -Wcast-align -Wcast-qual -Wmissing-declarations -Wpointer-arith -Wshadow -Wvla -Wwrite-strings
CXXFLAGS_WERROR ?= -Werror CXXFLAGS_WERROR ?= -Werror
CXXFLAGS += $(CXXFLAGS_WERROR) CXXFLAGS += $(CXXFLAGS_WERROR)
src/p_mach.cpp
+2 -2
View File
@@ -684,8 +684,8 @@ void PackMachBase<T>::pack4(OutputFile *fo, Filter &ft) // append PackHeader
} }
if (my_filetype == Mach_header::MH_EXECUTE) { if (my_filetype == Mach_header::MH_EXECUTE) {
// Get a writeable copy of the stub to make editing easier. // Get a writeable copy of the stub to make editing easier.
unsigned char upxstub[sz_stub_main]; ByteArray(upxstub, sz_stub_main);
memcpy(upxstub, stub_main, sizeof(upxstub)); memcpy(upxstub, stub_main, sz_stub_main);
Mach_header *const mhp = (Mach_header *)upxstub; Mach_header *const mhp = (Mach_header *)upxstub;
char *tail = (char *)(1+ mhp); char *tail = (char *)(1+ mhp);