Markus F.X.J. Oberhumer
839a78f2e0
Better fix for previous commit to avoid out-of-bounds pointer.
2024-02-27 11:20:29 +01:00
John Reiser
680ce0a7af
find_dt_ndx defends against overrun
...
https://github.com/upx/upx/issues/790
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=66344&q=label%3AProj-upx
modified: p_lx_elf.cpp
2024-02-26 14:32:02 -08:00
Markus F.X.J. Oberhumer
06b0de9c77
CI: work-around zig cc mips bad codegen for hard-float
2024-02-17 16:34:11 +01:00
Markus F.X.J. Oberhumer
76b0b7b1ae
all: clang-format
2024-02-14 21:29:51 +01:00
John Reiser
fabda4df3a
R_PPC64_REL24 is reallly "PC-rel. 26 bit, word aligned:
...
Just like R_PPC_REL24
modified: linker.cpp
2024-02-14 11:43:20 -08:00
Markus F.X.J. Oberhumer
fdcdaf596a
all: pacify clang-tidy, CI and cmake updates
2024-02-14 15:14:47 +01:00
Markus F.X.J. Oberhumer
ae6d3b9bff
all: more assorted cleanups
2024-02-09 14:48:47 +01:00
John Reiser
25aa0e2e46
un_asl_dynsym() should skip when !dynstr
...
https://github.com/upx/upx/issues/785
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=66302
modified: p_lx_elf.cpp
2024-02-08 19:32:03 -08:00
Markus F.X.J. Oberhumer
29ce4807fb
all: minor updates
2024-02-04 13:37:00 +01:00
John Reiser
41f6945be1
Fix auxv_up() to avoid SIGSEGV under valgrind
...
https://github.com/upx/upx/issues/784
modified: stub/src/amd64-linux.elf-main.c
modified: stub/src/i386-linux.elf-main.c
modified: ../misc/testsuite/upx_testsuite_1-expected_sha256sums.sh
plus all generated stub/*-linux.elf-fold.{h,map}
2024-02-03 13:58:53 -08:00
Markus F.X.J. Oberhumer
718ec468ff
all: more assorted cleanups; NFCI
2024-02-02 10:17:16 +01:00
John Reiser
d429801498
Avoid &file_image[file_size] because some Standards object
...
modified: p_lx_elf.cpp
2024-02-01 11:41:04 -08:00
Markus F.X.J. Oberhumer
024091e6b5
src: fix previous bounds checking commit
2024-01-31 20:52:19 +01:00
Markus F.X.J. Oberhumer
d849e9de98
src: add some bounds checking to MemBufferBase
2024-01-31 16:48:55 +01:00
John Reiser
c0e40da2ab
more checking of Mach_header when unpacking for MachOS
...
https://github.com/upx/upx/issues/783
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65532
modified: p_mach.cpp
2024-01-27 14:16:53 -08:00
John Reiser
dff3766501
Detect too-large bit-shift in elf_lookup of DT_GNUHASH
...
https://github.com/upx/upx/issues/782
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65776
modified: p_lx_elf.cpp
2024-01-27 13:38:25 -08:00
John Reiser
2767ec54e1
more checking of PackUnix::p_info at unpack
...
https://github.com/upx/upx/issues/781
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65864
modified: p_unix.cpp
2024-01-27 13:06:59 -08:00
John Reiser
ac72c02793
check nbucket earlier in DT_HASH on ELF
...
https://github.com/upx/upx/issues/780
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=66079
modified: p_lx_elf.cpp
2024-01-27 11:42:25 -08:00
John Reiser
69c51eee4d
better checking of DT_STRSZ for ELF
...
https://github.com/upx/upx/issues/779
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=66064
modified: p_lx_elf.cpp
modified: p_lx_elf.h
2024-01-27 11:11:07 -08:00
John Reiser
ff5a4eeb96
ELF versus --brute: addStubEntrySections() needs ph_forced_method()
...
https://github.com/upx/upx/issues/770
modified: p_lx_elf.cpp
2024-01-25 17:17:32 -08:00
John Reiser
b48f870701
Detect circular DT_HASH and DT_GNUHASH lookup
...
https://github.com/upx/upx/issues/775
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65811&q=label%3AProj-upx
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65840&q=label%3AProj-upx
2024-01-25 15:05:53 -08:00
John Reiser
10807ebdc2
Unpack 8-byte b_info only if (ph.version <= 11): 2001 or earlier
...
*x86 only: .e_entry too low
https://github.com/upx/upx/issues/774
modified: p_lx_elf.cpp
2024-01-25 09:06:46 -08:00
Markus F.X.J. Oberhumer
5d649f83ec
all: assorted cleanups
2024-01-24 20:53:14 +01:00
John Reiser
d615985b8a
elf_find_table_size() did not check for empty table
...
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65765&q=label%3AProj-upx
https://github.com/upx/upx/issues/771
modified: p_lx_elf.cpp
2024-01-18 19:11:12 -08:00
John Reiser
38ed4b2017
arm32, arm64 ABI for -static must preserve register 0
...
Also arm32 forgot to unmap the expanded de-compressor via the escape hatch.
https://github.com/upx/upx/issues/758
https://github.com/upx/upx/issues/768
modified: ../misc/testsuite/upx_testsuite_1-expected_sha256sums.sh
modified: stub/src/arm.v4a-linux.elf-entry.S
modified: stub/src/arm.v4a-linux.elf-fold.S
modified: stub/src/arm64-linux.elf-entry.S
modified: stub/src/arm64-linux.elf-fold.S
modified: stub/src/i386-linux.elf-main.c
modified: stub/src/amd64-linux.elf-main.c
plus associated *.h *.map *.dump
2024-01-12 15:39:18 -08:00
John Reiser
2ad0d51226
PeFile::rebuildImports(): Allow strlen() up to the very end of a logical block
...
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65650
https://github.com/upx/upx/issues/769
modified: pefile.cpp
2024-01-11 09:57:57 -08:00
John Reiser
e4a611bcae
PeFile ::readPeHeader should check ih.subsystem.
...
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65526
https://github.com/upx/upx/issues/767
modified: pefile.cpp
2024-01-10 16:28:17 -08:00
John Reiser
f3728d99b9
Check ph.method in PackMachBase::unpack
...
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65553
https://github.com/upx/upx/issues/766
modified: p_mach.cpp
2024-01-10 16:04:08 -08:00
John Reiser
b87f60a917
Check Mach_fat_arch.align
...
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65558
https://github.com/upx/upx/issues/765
modified: p_mach.cpp
2024-01-10 15:31:37 -08:00
John Reiser
28f26da6ab
Need more care in PackMachBase::canUnpack()
...
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65532
https://github.com/upx/upx/issues/764
modified: p_mach.cpp
2024-01-10 15:14:54 -08:00
John Reiser
d3e780d617
Unpacking ELF requires e_phnum at least 2
...
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65535
https://github.com/upx/upx/issues/763
modified: p_lx_elf.cpp
2024-01-10 14:07:58 -08:00
John Reiser
d549c2b5c9
More care when recovering from slid b_info
...
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65531
https://github.com/upx/upx/issues/762
modified: p_lx_elf.cpp
2024-01-10 13:38:18 -08:00
John Reiser
f310ce376e
Beware fuzzer setting compressed size too small
...
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65519
https://github.com/upx/upx/issues/761
modified: p_unix.cpp
2024-01-10 11:20:47 -08:00
John Reiser
553fc9b1fb
invert_pt_dynamic: Compilers differ, unsigned vs. signed
...
modified: p_lx_elf.cpp
2024-01-10 10:33:33 -08:00
John Reiser
6dde9f7dc0
find_overlay_offset() did not check carefully enough
...
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65518
https://github.com/upx/upx/issues/760
modified: p_unix.cpp
2024-01-10 10:05:28 -08:00
John Reiser
3dca1175e5
invert_pt_dynamic() needs better checking for malformed input
...
https://github.com/upx/upx/issues/759
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65510
modified: p_lx_elf.cpp
2024-01-10 09:41:12 -08:00
John Reiser
09c5e38322
arm64-linux.elf ABI owns x0 at execve()?
...
https://github.com/upx/upx/issues/758
modified: ../misc/testsuite/upx_testsuite_1-expected_sha256sums.sh
modified: stub/arm64-linux.elf-fold.h
modified: stub/src/amd64-linux.elf-main.c
modified: stub/src/arm64-linux.elf-fold.S
modified: stub/tmp/arm64-linux.elf-fold.map
2024-01-09 12:17:01 -08:00
John Reiser
fe6f1f0bb6
arm64-linux.elf-fold.S typo (eyesight)
...
https://github.com/upx/upx/issues/743
modified: misc/testsuite/upx_testsuite_1-expected_sha256sums.sh
modified: src/stub/arm64-linux.elf-fold.h
modified: src/stub/src/arm64-linux.elf-fold.S
2024-01-09 10:01:07 -08:00
Markus F.X.J. Oberhumer
57b2fb4c62
all: post-release version bump
2024-01-04 02:52:22 +01:00
Markus F.X.J. Oberhumer
1bcf709fcf
all: bump version date
2024-01-03 17:54:43 +01:00
Markus F.X.J. Oberhumer
47fc230893
all: welcome 2024
2024-01-03 17:47:25 +01:00
Markus F.X.J. Oberhumer
f598fa13a9
clang-format
2024-01-03 17:36:43 +01:00
Markus F.X.J. Oberhumer
0500e7d016
CI updates; cxxlib.h cleanups
2023-12-28 04:42:41 +01:00
Markus F.X.J. Oberhumer
778663ae69
CI updates
2023-12-21 23:01:52 +01:00
Markus F.X.J. Oberhumer
51a6a5cca5
src: rename ptr_reinterpret_cast to ptr_static_cast; misc cleanups
2023-12-20 11:44:01 +01:00
Markus F.X.J. Oberhumer
3326c86e91
cmake update
2023-12-19 16:11:23 +01:00
Markus F.X.J. Oberhumer
decc1efb74
CI updates
2023-12-17 07:35:39 +01:00
Markus F.X.J. Oberhumer
fc6e3840b7
CI updates
2023-12-09 08:52:25 +01:00
Markus F.X.J. Oberhumer
1e6e4043ed
CI updates and minor cleanups.
2023-12-02 01:48:26 +01:00
John Reiser
ed2633bf95
Honor .p_align <= 64K; else assume 4K is also available
...
https://github.com/upx/upx/issues/737
modified: p_lx_elf.cpp
2023-11-26 11:46:12 -08:00
Markus F.X.J. Oberhumer
3e70021406
all: more minor cleanups
2023-11-26 18:30:47 +01:00
Markus F.X.J. Oberhumer
bf8dd31914
all: minor cleanups
2023-11-21 20:29:54 +01:00
John Reiser
d4e94f5086
Fix varying page size on arm64
...
https://github.com/upx/upx/issues/734
modified: stub/src/amd64-linux.elf-fold.S
modified: stub/src/amd64-linux.elf-main.c
modified: stub/src/arm64-linux.elf-entry.S
modified: stub/src/arm64-linux.elf-fold.S
modified: ../misc/testsuite/upx_testsuite_1-expected_sha256sums.sh
... plus associated stub/*.h etc
2023-11-17 15:10:31 -08:00
John Reiser
ae77fd60bb
initial headway is limited by both file_size and mhcmdi.sizeofcmds
...
https://github.com/upx/upx/issues/732
modified: p_mach.cpp
2023-11-17 07:28:21 -08:00
Markus F.X.J. Oberhumer
e79c790264
CI updates
2023-11-17 11:50:52 +01:00
Markus F.X.J. Oberhumer
46029bb8a0
CI updates
2023-11-15 13:06:29 +01:00
Markus F.X.J. Oberhumer
f74c225338
CI updates
2023-11-14 19:15:34 +01:00
Markus F.X.J. Oberhumer
c479fe32b3
cmake update
2023-11-13 11:29:17 +01:00
Markus F.X.J. Oberhumer
d7142312c9
CI updates
2023-11-08 10:08:19 +01:00
Markus F.X.J. Oberhumer
283ab0e7ea
CI updates and assorted cleanups
2023-11-06 19:29:40 +01:00
Markus F.X.J. Oberhumer
11970d276d
CI updates
2023-11-04 06:30:07 +01:00
Markus F.X.J. Oberhumer
4f0f977f04
CI updates and cleanups
2023-11-03 17:52:46 +01:00
Markus F.X.J. Oberhumer
ceb2b56b71
all: post-release version bump
2023-11-01 15:07:18 +01:00
Markus F.X.J. Oberhumer
d14fa5f8a4
all: prepare for release
2023-11-01 12:00:03 +01:00
Markus F.X.J. Oberhumer
ecb3f83e83
CI updates
2023-11-01 11:28:35 +01:00
Markus F.X.J. Oberhumer
3b7d25ac49
CI updates
2023-11-01 08:48:27 +01:00
Markus F.X.J. Oberhumer
e964d4acf3
src/util: change TriBool logic to use a bool template parameter
2023-10-31 12:24:44 +01:00
Markus F.X.J. Oberhumer
b094ad4f2b
CI updates
2023-10-31 10:34:55 +01:00
Markus F.X.J. Oberhumer
19c6b969ab
src/options: fix bad TriBool ThirdValue for pefile compress_resources
2023-10-30 21:36:36 +01:00
Markus F.X.J. Oberhumer
acfda848cd
src/check: add some more tribool checks
2023-10-30 20:29:05 +01:00
John Reiser
52400e2561
/proc/self/exe now is optional
...
... for the benefit of 'unshare', 'chroot', etc.
If not present, then upx run-time stub unmaps all pages of original main program.
https://github.com/upx/upx/issues/721
modified: stub/src/amd64-linux.elf-entry.S
modified: stub/src/amd64-linux.elf-fold.S
modified: stub/src/arm.v4a-linux.elf-entry.S
modified: stub/src/arm.v4a-linux.elf-fold.S
modified: stub/src/arm64-linux.elf-entry.S
modified: stub/src/arm64-linux.elf-fold.S
modified: stub/src/i386-linux.elf-fold.S
modified: stub/src/mipsel.r3000-linux.elf-fold.S
modified: stub/src/powerpc-linux.elf-fold.S
modified: stub/src/powerpc64le-linux.elf-fold.S
modified: ../misc/testsuite/upx_testsuite_1-expected_sha256sums.sh
... plus all associaed *.h, *.map, *.dump in stub/
2023-10-30 08:23:52 -07:00
Markus F.X.J. Oberhumer
f62576a2be
CI updates and minor cleanups
2023-10-30 14:15:35 +01:00
Markus F.X.J. Oberhumer
19bf9f59e9
src: clang-format stub/tools/armpe/armpe_tester.c
2023-10-30 13:07:20 +01:00
Markus F.X.J. Oberhumer
fadf7cfc7b
src: work on packed_struct cleanup
2023-10-30 12:55:07 +01:00
Markus F.X.J. Oberhumer
ec0c9399fa
src: clang-format conf.h
2023-10-30 12:30:58 +01:00
Markus F.X.J. Oberhumer
37b923245d
all: various cleanups
2023-10-30 12:17:51 +01:00
Markus F.X.J. Oberhumer
38a676f6f7
src: introduce upx::ptr_reinterpret_cast
2023-10-29 16:52:24 +01:00
Markus F.X.J. Oberhumer
cd1df6f6b1
all: update version
2023-10-29 15:37:13 +01:00
Markus F.X.J. Oberhumer
4a24fe8c53
CI updates and cleanups
2023-10-29 15:12:33 +01:00
Markus F.X.J. Oberhumer
6dac3dd248
CI updates
2023-10-27 09:24:06 +02:00
Markus F.X.J. Oberhumer
37d393cbc8
src: prefer using SetFileTime() on Windows
2023-10-27 06:58:14 +02:00
Markus F.X.J. Oberhumer
8102137ad7
all: post-release version bump
2023-10-26 12:25:13 +02:00
Markus F.X.J. Oberhumer
9c46f4653f
all: prepare for release
2023-10-26 11:09:48 +02:00
Markus F.X.J. Oberhumer
29b4752d0e
src: add some noexcept
2023-10-26 00:28:36 +02:00
Markus F.X.J. Oberhumer
facabd68d7
all: more minor cleanups
2023-10-24 23:56:55 +02:00
Markus F.X.J. Oberhumer
18f043015e
all: minor cleanups
2023-10-24 22:54:54 +02:00
Markus F.X.J. Oberhumer
ab259a1af9
src/pefile: try to clean up reloc handling
2023-10-24 11:47:23 +02:00
Markus F.X.J. Oberhumer
1dd96a7628
src/pefile: stricter reloc checks; cleanups
2023-10-23 14:26:37 +02:00
Markus F.X.J. Oberhumer
1ee7ecb1f0
all: prefer using utimensat()
2023-10-22 13:29:26 +02:00
Markus F.X.J. Oberhumer
67548a4d9a
src: minor cleanups
2023-10-22 00:45:06 +02:00
Markus F.X.J. Oberhumer
9fbe95ad48
all: cleanups
2023-10-21 11:22:18 +02:00
Markus F.X.J. Oberhumer
a1d090a6fd
src/stub: add a "clang-format off" directive
2023-10-15 10:55:15 +02:00
Markus F.X.J. Oberhumer
4870765e1b
all: disable packing macOS binaries for now
2023-10-15 10:15:46 +02:00
Markus F.X.J. Oberhumer
d8be2ed276
src/pefile.cpp: cleanup reloc handling and add more checks
2023-10-14 19:24:44 +02:00
Markus F.X.J. Oberhumer
2b371e99bd
src/util: minor xspan enhancements
2023-10-14 05:58:47 +02:00
John Reiser
65b06f6046
More LZMA inSize (srclen) defense
...
https://github.com/upx/upx/issues/717
modified: stub/src/amd64-darwin.dylib-entry.S fixed
modified: stub/src/amd64-darwin.macho-entry.S fixed
modified: stub/src/amd64-linux.elf-so_entry.S comment-only
modified: stub/src/i386-linux.elf-so_entry.S comment-only
modified: stub/amd64-darwin.dylib-entry.h
modified: stub/amd64-darwin.macho-entry.h
modified: stub/amd64-linux.elf-so_entry.h
modified: stub/tmp/amd64-darwin.dylib-entry.bin.dump
modified: stub/tmp/amd64-darwin.macho-entry.bin.dump
modified: stub/tmp/amd64-linux.elf-so_entry.bin.dump
Find+fix steps that were performed:
1. Find all 'add' instructions that compute "eof".
NRV run-time decompressors ignore srclen, so 'add' can be ignored for them.
$ cd upx-devel4/src/stub
$ grep -sr 'add.*eof' src | grep -v 'nrv2._d.*.S' | sort
src/amd64-darwin.dylib-entry.S: addq src,lsrc; push lsrc // &input_eof
src/amd64-darwin.macho-entry.S: addq src,lsrc; push lsrc // &input_eof
src/amd64-linux.elf-entry.S: addq src,lsrc; push lsrc // &input_eof
src/amd64-linux.elf-so_entry.S: addq src,lsrc; push lsrc // MATCH_05 &input_eof
src/amd64-linux.elf-so_main.c: void *mfd_addr = Pmap(0, sizeof(code), PROT_READ|PROT_EXEC, MAP_PRIVATE, mfd, 0);
src/amd64-linux.shlib-init.S: addq src,lsrc; push lsrc // &input_eof
src/arch/amd64/lzma_d.S:// addq src,lsrc; push lsrc // &input_eof
src/i386-expand.S: add src,%ecx; push %ecx // MATCH_52 eof_src
src/i386-linux.elf-so_entry.S: add src,lsrc; push lsrc // MATCH_05 &input_eof
2. Case-by-case inspection
src/amd64-darwin.dylib-entry.S: addq src,lsrc; push lsrc // &input_eof
restoring 'subq' is added in this commit
src/amd64-darwin.macho-entry.S: addq src,lsrc; push lsrc // &input_eof
restoring 'subq' is added in this commit
src/amd64-linux.elf-entry.S: addq src,lsrc; push lsrc // &input_eof
a restoring 'subq' is already next
src/amd64-linux.elf-so_entry.S: addq src,lsrc; push lsrc // MATCH_05 &input_eof
lsrc is dead for inlined nrv2b
src/amd64-linux.elf-so_main.c: void *mfd_addr = Pmap(0, sizeof(code), PROT_READ|PROT_EXEC, MAP_PRIVATE, mfd, 0);
.c code
src/amd64-linux.shlib-init.S: addq src,lsrc; push lsrc // &input_eof
restoring 'subq' is already next
src/arch/amd64/lzma_d.S:// addq src,lsrc; push lsrc // &input_eof
comment that explains preceding actions in ELFMAINX; a restoring 'subq' is already next
src/i386-expand.S: add src,%ecx; push %ecx // MATCH_52 eof_src
%ecx is dead
src/i386-linux.elf-so_entry.S: add src,lsrc; push lsrc // MATCH_05 &input_eof
lsrc is dead for inlined nrv2b
2023-10-12 10:41:13 -07:00
John Reiser
0515be4334
LZMA on AMD64 had bug in calling sequence, leading to random exit(127)
...
LzmaDecode randomly decided that the input had ended in the middle,
because of error in interface between ELFMAINX and the decoder.
Thanks to Kevin Gosse!
https://github.com/upx/upx/pull/716
https://github.com/MichalStrehovsky/PublishAotCompressed/issues/11
2023-10-06 14:14:32 -07:00
Markus F.X.J. Oberhumer
e32de83758
CI updates
2023-10-05 12:23:17 +02:00
Markus F.X.J. Oberhumer
e767461f65
src: more clang-format
2023-10-05 11:53:02 +02:00
Markus F.X.J. Oberhumer
632c7c4826
all: assorted cleanups; introduce undocumented '--sysinfo' option
2023-10-05 03:51:27 +02:00